Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: src/inspector/v8-heap-profiler-agent-impl.cc

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-heap-profiler-agent-impl.h ('k') | src/inspector/v8-inspector-impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-heap-profiler-agent-impl.cc
diff --git a/src/inspector/v8-heap-profiler-agent-impl.cc b/src/inspector/v8-heap-profiler-agent-impl.cc
index 4ccef1c01532353eaed29c3ea25189cef2d97a12..84c890bf3f72bf0c6f3937dc504b76f490a1180e 100644
--- a/src/inspector/v8-heap-profiler-agent-impl.cc
+++ b/src/inspector/v8-heap-profiler-agent-impl.cc
@@ -30,7 +30,7 @@ static const char samplingHeapProfilerInterval[] =
class HeapSnapshotProgress final : public v8::ActivityControl {
public:
- HeapSnapshotProgress(protocol::HeapProfiler::Frontend* frontend)
+ explicit HeapSnapshotProgress(protocol::HeapProfiler::Frontend* frontend)
: m_frontend(frontend) {}
ControlOption ReportProgressValue(int done, int total) override {
m_frontend->reportHeapSnapshotProgress(done, total,
@@ -78,7 +78,7 @@ class GlobalObjectNameResolver final
class HeapSnapshotOutputStream final : public v8::OutputStream {
public:
- HeapSnapshotOutputStream(protocol::HeapProfiler::Frontend* frontend)
+ explicit HeapSnapshotOutputStream(protocol::HeapProfiler::Frontend* frontend)
: m_frontend(frontend) {}
void EndOfStream() override {}
int GetChunkSize() override { return 102400; }
@@ -113,7 +113,7 @@ class InspectableHeapObject final : public V8InspectorSession::Inspectable {
class HeapStatsStream final : public v8::OutputStream {
public:
- HeapStatsStream(protocol::HeapProfiler::Frontend* frontend)
+ explicit HeapStatsStream(protocol::HeapProfiler::Frontend* frontend)
: m_frontend(frontend) {}
void EndOfStream() override {}
« no previous file with comments | « src/inspector/v8-heap-profiler-agent-impl.h ('k') | src/inspector/v8-inspector-impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698