Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: src/inspector/v8-inspector-impl.h

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/v8-heap-profiler-agent-impl.cc ('k') | src/inspector/v8-inspector-session-impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef V8_INSPECTOR_V8INSPECTORIMPL_H_ 31 #ifndef V8_INSPECTOR_V8INSPECTORIMPL_H_
32 #define V8_INSPECTOR_V8INSPECTORIMPL_H_ 32 #define V8_INSPECTOR_V8INSPECTORIMPL_H_
33 33
34 #include <vector>
35
34 #include "src/base/macros.h" 36 #include "src/base/macros.h"
35 #include "src/inspector/protocol/Protocol.h" 37 #include "src/inspector/protocol/Protocol.h"
36 38
37 #include "include/v8-debug.h" 39 #include "include/v8-debug.h"
38 #include "include/v8-inspector.h" 40 #include "include/v8-inspector.h"
39 41
40 #include <vector>
41
42 namespace v8_inspector { 42 namespace v8_inspector {
43 43
44 class InspectedContext; 44 class InspectedContext;
45 class V8ConsoleMessageStorage; 45 class V8ConsoleMessageStorage;
46 class V8Debugger; 46 class V8Debugger;
47 class V8DebuggerAgentImpl; 47 class V8DebuggerAgentImpl;
48 class V8InspectorSessionImpl; 48 class V8InspectorSessionImpl;
49 class V8ProfilerAgentImpl; 49 class V8ProfilerAgentImpl;
50 class V8RuntimeAgentImpl; 50 class V8RuntimeAgentImpl;
51 class V8StackTraceImpl; 51 class V8StackTraceImpl;
52 52
53 class V8InspectorImpl : public V8Inspector { 53 class V8InspectorImpl : public V8Inspector {
54 DISALLOW_COPY_AND_ASSIGN(V8InspectorImpl);
55
56 public: 54 public:
57 V8InspectorImpl(v8::Isolate*, V8InspectorClient*); 55 V8InspectorImpl(v8::Isolate*, V8InspectorClient*);
58 ~V8InspectorImpl() override; 56 ~V8InspectorImpl() override;
59 57
60 v8::Isolate* isolate() const { return m_isolate; } 58 v8::Isolate* isolate() const { return m_isolate; }
61 V8InspectorClient* client() { return m_client; } 59 V8InspectorClient* client() { return m_client; }
62 V8Debugger* debugger() { return m_debugger.get(); } 60 V8Debugger* debugger() { return m_debugger.get(); }
63 61
64 v8::MaybeLocal<v8::Value> runCompiledScript(v8::Local<v8::Context>, 62 v8::MaybeLocal<v8::Value> runCompiledScript(v8::Local<v8::Context>,
65 v8::Local<v8::Script>); 63 v8::Local<v8::Script>);
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 using ContextsByGroupMap = 134 using ContextsByGroupMap =
137 protocol::HashMap<int, std::unique_ptr<ContextByIdMap>>; 135 protocol::HashMap<int, std::unique_ptr<ContextByIdMap>>;
138 ContextsByGroupMap m_contexts; 136 ContextsByGroupMap m_contexts;
139 137
140 using SessionMap = protocol::HashMap<int, V8InspectorSessionImpl*>; 138 using SessionMap = protocol::HashMap<int, V8InspectorSessionImpl*>;
141 SessionMap m_sessions; 139 SessionMap m_sessions;
142 140
143 using ConsoleStorageMap = 141 using ConsoleStorageMap =
144 protocol::HashMap<int, std::unique_ptr<V8ConsoleMessageStorage>>; 142 protocol::HashMap<int, std::unique_ptr<V8ConsoleMessageStorage>>;
145 ConsoleStorageMap m_consoleStorageMap; 143 ConsoleStorageMap m_consoleStorageMap;
144
145 DISALLOW_COPY_AND_ASSIGN(V8InspectorImpl);
146 }; 146 };
147 147
148 } // namespace v8_inspector 148 } // namespace v8_inspector
149 149
150 #endif // V8_INSPECTOR_V8INSPECTORIMPL_H_ 150 #endif // V8_INSPECTOR_V8INSPECTORIMPL_H_
OLDNEW
« no previous file with comments | « src/inspector/v8-heap-profiler-agent-impl.cc ('k') | src/inspector/v8-inspector-session-impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698