Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/inspector/v8-regex.cc

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)
Patch Set: addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/v8-regex.h ('k') | src/inspector/v8-runtime-agent-impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/inspector/v8-regex.h" 5 #include "src/inspector/v8-regex.h"
6 6
7 #include <limits.h>
8
7 #include "src/inspector/string-util.h" 9 #include "src/inspector/string-util.h"
8 #include "src/inspector/v8-inspector-impl.h" 10 #include "src/inspector/v8-inspector-impl.h"
9 11
10 #include "include/v8-inspector.h" 12 #include "include/v8-inspector.h"
11 13
12 #include <limits.h>
13
14 namespace v8_inspector { 14 namespace v8_inspector {
15 15
16 V8Regex::V8Regex(V8InspectorImpl* inspector, const String16& pattern, 16 V8Regex::V8Regex(V8InspectorImpl* inspector, const String16& pattern,
17 bool caseSensitive, bool multiline) 17 bool caseSensitive, bool multiline)
18 : m_inspector(inspector) { 18 : m_inspector(inspector) {
19 v8::Isolate* isolate = m_inspector->isolate(); 19 v8::Isolate* isolate = m_inspector->isolate();
20 v8::HandleScope handleScope(isolate); 20 v8::HandleScope handleScope(isolate);
21 v8::Local<v8::Context> context = m_inspector->regexContext(); 21 v8::Local<v8::Context> context = m_inspector->regexContext();
22 v8::Context::Scope contextScope(context); 22 v8::Context::Scope contextScope(context);
23 v8::TryCatch tryCatch(isolate); 23 v8::TryCatch tryCatch(isolate);
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 if (matchLength) { 84 if (matchLength) {
85 v8::Local<v8::Value> match; 85 v8::Local<v8::Value> match;
86 if (!result->Get(context, 0).ToLocal(&match)) return -1; 86 if (!result->Get(context, 0).ToLocal(&match)) return -1;
87 *matchLength = match.As<v8::String>()->Length(); 87 *matchLength = match.As<v8::String>()->Length();
88 } 88 }
89 89
90 return matchOffset.As<v8::Int32>()->Value() + startFrom; 90 return matchOffset.As<v8::Int32>()->Value() + startFrom;
91 } 91 }
92 92
93 } // namespace v8_inspector 93 } // namespace v8_inspector
OLDNEW
« no previous file with comments | « src/inspector/v8-regex.h ('k') | src/inspector/v8-runtime-agent-impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698