Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter.

Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter. (Closed)

Created:
4 years, 3 months ago by samuong

Modified:
4 years, 3 months ago

Reviewers:
stgao

CC:
chromium-reviews, samuong+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[chromedriver] Set page load strategy via constructor rather than a setter. BUG=chromedriver:1495 TBR=stgao@chromium.org Committed: https://crrev.com/ad84797d8c8580d09d71d2b483865cc2e712c1e4 Cr-Commit-Position: refs/heads/master@{#417027}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -32 lines)			Patch
M	chrome/test/chromedriver/chrome/chrome.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/chrome_android_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/chrome_android_impl.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome/chrome_desktop_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/chrome_desktop_impl.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome/chrome_impl.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/chrome_impl.cc	View	2 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/chrome_remote_impl.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome/chrome_remote_impl.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/stub_chrome.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome/stub_chrome.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/test/chromedriver/chrome_launcher.cc	View	3 chunks	+19 lines, -10 lines	0 comments	Download
M	chrome/test/chromedriver/session_commands.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319223002/1

4 years, 3 months ago (2016-09-07 18:47:58 UTC) #2

commit-bot: I haz the power

4 years, 3 months ago (2016-09-07 19:35:34 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ad84797d8c8580d09d71d2b483865cc2e712c1e4
Cr-Commit-Position: refs/heads/master@{#417027}