chrome/test/chromedriver/chrome/stub_chrome.h - Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/stub_chrome.h

Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/stub_chrome.h

diff --git a/chrome/test/chromedriver/chrome/stub_chrome.h b/chrome/test/chromedriver/chrome/stub_chrome.h

index 1362aa744be55c5445297a63b4157923128b7619..99370d1e3c972b5bbab3b71ccafa7850c2cca398 100644

--- a/chrome/test/chromedriver/chrome/stub_chrome.h

+++ b/chrome/test/chromedriver/chrome/stub_chrome.h

@@ -33,7 +33,6 @@ class StubChrome : public Chrome {

bool IsMobileEmulationEnabled() const override;

bool HasTouchScreen() const override;

std::string page_load_strategy() const override;

- void set_page_load_strategy(std::string strategy) override;

Status Quit() override;

private: