Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: chrome/test/chromedriver/chrome/chrome_android_impl.h

Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_CHROMEDRIVER_CHROME_CHROME_ANDROID_IMPL_H_ 5 #ifndef CHROME_TEST_CHROMEDRIVER_CHROME_CHROME_ANDROID_IMPL_H_
6 #define CHROME_TEST_CHROMEDRIVER_CHROME_CHROME_ANDROID_IMPL_H_ 6 #define CHROME_TEST_CHROMEDRIVER_CHROME_CHROME_ANDROID_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "chrome/test/chromedriver/chrome/chrome_impl.h" 12 #include "chrome/test/chromedriver/chrome/chrome_impl.h"
13 13
14 class Device; 14 class Device;
15 class DevToolsClient; 15 class DevToolsClient;
16 class DevToolsHttpClient; 16 class DevToolsHttpClient;
17 17
18 class ChromeAndroidImpl : public ChromeImpl { 18 class ChromeAndroidImpl : public ChromeImpl {
19 public: 19 public:
20 ChromeAndroidImpl( 20 ChromeAndroidImpl(
21 std::unique_ptr<DevToolsHttpClient> http_client, 21 std::unique_ptr<DevToolsHttpClient> http_client,
22 std::unique_ptr<DevToolsClient> websocket_client, 22 std::unique_ptr<DevToolsClient> websocket_client,
23 ScopedVector<DevToolsEventListener>& devtools_event_listeners, 23 ScopedVector<DevToolsEventListener>& devtools_event_listeners,
24 std::unique_ptr<PortReservation> port_reservation, 24 std::unique_ptr<PortReservation> port_reservation,
25 std::string page_load_strategy,
25 std::unique_ptr<Device> device); 26 std::unique_ptr<Device> device);
26 ~ChromeAndroidImpl() override; 27 ~ChromeAndroidImpl() override;
27 28
28 // Overridden from Chrome: 29 // Overridden from Chrome:
29 Status GetAsDesktop(ChromeDesktopImpl** desktop) override; 30 Status GetAsDesktop(ChromeDesktopImpl** desktop) override;
30 std::string GetOperatingSystemName() override; 31 std::string GetOperatingSystemName() override;
31 32
32 // Overridden from ChromeImpl: 33 // Overridden from ChromeImpl:
33 bool HasTouchScreen() const override; 34 bool HasTouchScreen() const override;
34 Status QuitImpl() override; 35 Status QuitImpl() override;
35 36
36 private: 37 private:
37 std::unique_ptr<Device> device_; 38 std::unique_ptr<Device> device_;
38 }; 39 };
39 40
40 #endif // CHROME_TEST_CHROMEDRIVER_CHROME_CHROME_ANDROID_IMPL_H_ 41 #endif // CHROME_TEST_CHROMEDRIVER_CHROME_CHROME_ANDROID_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome.h ('k') | chrome/test/chromedriver/chrome/chrome_android_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698