chrome/test/chromedriver/chrome/chrome_desktop_impl.h - Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.h

Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.h

diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.h b/chrome/test/chromedriver/chrome/chrome_desktop_impl.h

index 537cea67a7d8d23be060156f7541e9c18cc25287..8923d54029f0750c6310552ed03776677f572a1d 100644

--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.h

+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.h

@@ -31,6 +31,7 @@ class ChromeDesktopImpl : public ChromeImpl {

std::unique_ptr<DevToolsClient> websocket_client,

ScopedVector<DevToolsEventListener>& devtools_event_listeners,

std::unique_ptr<PortReservation> port_reservation,

+ std::string page_load_strategy,

base::Process process,

const base::CommandLine& command,

base::ScopedTempDir* user_data_dir,