Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.cc

Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_remote_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/chrome_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.cc b/chrome/test/chromedriver/chrome/chrome_impl.cc
index 7e70fc3f1dd8233c5d1faf441692ac9679740039..5cee177811b8dcc99b083f85b47f00a74e2c0297 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_impl.cc
@@ -154,11 +154,6 @@ std::string ChromeImpl::page_load_strategy() const {
return page_load_strategy_;
}
-void ChromeImpl::set_page_load_strategy(std::string strategy) {
- // Support for page load strategy already checked when capability is parsed.
- page_load_strategy_ = strategy;
-}
-
Status ChromeImpl::Quit() {
Status status = QuitImpl();
if (status.IsOk())
@@ -170,10 +165,12 @@ ChromeImpl::ChromeImpl(
std::unique_ptr<DevToolsHttpClient> http_client,
std::unique_ptr<DevToolsClient> websocket_client,
ScopedVector<DevToolsEventListener>& devtools_event_listeners,
- std::unique_ptr<PortReservation> port_reservation)
+ std::unique_ptr<PortReservation> port_reservation,
+ std::string page_load_strategy)
: quit_(false),
devtools_http_client_(std::move(http_client)),
devtools_websocket_client_(std::move(websocket_client)),
- port_reservation_(std::move(port_reservation)) {
+ port_reservation_(std::move(port_reservation)),
+ page_load_strategy_(page_load_strategy) {
devtools_event_listeners_.swap(devtools_event_listeners);
}
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_remote_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698