Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
index f59e73307c6e1bcd6bf33316ee8a119f6fd0d02e..5ab7fb1efb0db91c35ad8b3972dbcb7bd3ae58ca 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
@@ -75,6 +75,7 @@ ChromeDesktopImpl::ChromeDesktopImpl(
std::unique_ptr<DevToolsClient> websocket_client,
ScopedVector<DevToolsEventListener>& devtools_event_listeners,
std::unique_ptr<PortReservation> port_reservation,
+ std::string page_load_strategy,
base::Process process,
const base::CommandLine& command,
base::ScopedTempDir* user_data_dir,
@@ -83,7 +84,8 @@ ChromeDesktopImpl::ChromeDesktopImpl(
: ChromeImpl(std::move(http_client),
std::move(websocket_client),
devtools_event_listeners,
- std::move(port_reservation)),
+ std::move(port_reservation),
+ page_load_strategy),
process_(std::move(process)),
command_(command),
network_connection_enabled_(network_emulation_enabled),
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698