Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: chrome/test/chromedriver/chrome/chrome_remote_impl.cc

Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_remote_impl.h ('k') | chrome/test/chromedriver/chrome/stub_chrome.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/chrome_remote_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_remote_impl.cc b/chrome/test/chromedriver/chrome/chrome_remote_impl.cc
index 2fcd6f318f4ddcb189c74258a34324df3d8161e2..5b9a669d29a1cb0e71f6b6697426fb33fd561609 100644
--- a/chrome/test/chromedriver/chrome/chrome_remote_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_remote_impl.cc
@@ -14,11 +14,13 @@
ChromeRemoteImpl::ChromeRemoteImpl(
std::unique_ptr<DevToolsHttpClient> http_client,
std::unique_ptr<DevToolsClient> websocket_client,
- ScopedVector<DevToolsEventListener>& devtools_event_listeners)
+ ScopedVector<DevToolsEventListener>& devtools_event_listeners,
+ std::string page_load_strategy)
: ChromeImpl(std::move(http_client),
std::move(websocket_client),
devtools_event_listeners,
- std::unique_ptr<PortReservation>()) {}
+ std::unique_ptr<PortReservation>(),
+ page_load_strategy) {}
ChromeRemoteImpl::~ChromeRemoteImpl() {}
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_remote_impl.h ('k') | chrome/test/chromedriver/chrome/stub_chrome.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698