Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/test/chromedriver/chrome/chrome_android_impl.cc

Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_android_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_android_impl.cc b/chrome/test/chromedriver/chrome/chrome_android_impl.cc
index e5e1ead5e240232189e89377ba00e8855bfe9aac..83c4213f9ae8709f067a49a16e3c7e444558aa89 100644
--- a/chrome/test/chromedriver/chrome/chrome_android_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_android_impl.cc
@@ -18,11 +18,13 @@ ChromeAndroidImpl::ChromeAndroidImpl(
std::unique_ptr<DevToolsClient> websocket_client,
ScopedVector<DevToolsEventListener>& devtools_event_listeners,
std::unique_ptr<PortReservation> port_reservation,
+ std::string page_load_strategy,
std::unique_ptr<Device> device)
: ChromeImpl(std::move(http_client),
std::move(websocket_client),
devtools_event_listeners,
- std::move(port_reservation)),
+ std::move(port_reservation),
+ page_load_strategy),
device_(std::move(device)) {}
ChromeAndroidImpl::~ChromeAndroidImpl() {}
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_android_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_desktop_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698