chrome/test/chromedriver/chrome/chrome_remote_impl.h - Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_remote_impl.h

Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/chrome_remote_impl.h

diff --git a/chrome/test/chromedriver/chrome/chrome_remote_impl.h b/chrome/test/chromedriver/chrome/chrome_remote_impl.h

index 30340f43479f188c1958e40aadb42cbe0ad130fd..656b2aed5c61778339e3c4b4ac5ebcfa4fb28e51 100644

--- a/chrome/test/chromedriver/chrome/chrome_remote_impl.h

+++ b/chrome/test/chromedriver/chrome/chrome_remote_impl.h

@@ -19,7 +19,8 @@ class ChromeRemoteImpl : public ChromeImpl {

ChromeRemoteImpl(

std::unique_ptr<DevToolsHttpClient> http_client,

std::unique_ptr<DevToolsClient> websocket_client,

- ScopedVector<DevToolsEventListener>& devtools_event_listeners);

+ ScopedVector<DevToolsEventListener>& devtools_event_listeners,

+ std::string page_load_strategy);

~ChromeRemoteImpl() override;

// Overridden from Chrome.