Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5667)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.h

Issue 2319223002: [chromedriver] Set page load strategy via constructor rather than a setter. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_impl.h
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.h b/chrome/test/chromedriver/chrome/chrome_impl.h
index 1e0318aa2811071f6966577ebd513f8cf87c6f65..17efffd09b7e5b059cac179ff5c4dc896510280b 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.h
+++ b/chrome/test/chromedriver/chrome/chrome_impl.h
@@ -43,14 +43,14 @@ class ChromeImpl : public Chrome {
bool IsMobileEmulationEnabled() const override;
bool HasTouchScreen() const override;
std::string page_load_strategy() const override;
- void set_page_load_strategy(std::string strategy) override;
Status Quit() override;
protected:
ChromeImpl(std::unique_ptr<DevToolsHttpClient> http_client,
std::unique_ptr<DevToolsClient> websocket_client,
ScopedVector<DevToolsEventListener>& devtools_event_listeners,
- std::unique_ptr<PortReservation> port_reservation);
+ std::unique_ptr<PortReservation> port_reservation,
+ std::string page_load_strategy);
virtual Status QuitImpl() = 0;
@@ -59,7 +59,6 @@ class ChromeImpl : public Chrome {
std::unique_ptr<DevToolsClient> devtools_websocket_client_;
private:
- std::string page_load_strategy_;
typedef std::list<linked_ptr<WebViewImpl> > WebViewList;
void UpdateWebViews(const WebViewsInfo& views_info);
@@ -68,6 +67,7 @@ class ChromeImpl : public Chrome {
WebViewList web_views_;
ScopedVector<DevToolsEventListener> devtools_event_listeners_;
std::unique_ptr<PortReservation> port_reservation_;
+ std::string page_load_strategy_;
};
#endif // CHROME_TEST_CHROMEDRIVER_CHROME_CHROME_IMPL_H_
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.cc ('k') | chrome/test/chromedriver/chrome/chrome_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698