Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2259383002: Consistently use namespaced base::Version in extensions code. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 4 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistently use namespaced base::Version in extensions code. BUG=639416 Committed: https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79 Cr-Commit-Position: refs/heads/master@{#413496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -90 lines) Patch
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 19 chunks +36 lines, -33 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/external_registry_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/pending_extension_info.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/pending_extension_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/pending_extension_manager.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/updater/update_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/update_service_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/user_script_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/shared_module_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/update_manifest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
pwnall
Can you please take a look? This is a pretty mechanic CL.
4 years, 4 months ago (2016-08-19 20:23:39 UTC) #2
Finnur
LGTM
4 years, 4 months ago (2016-08-22 10:52:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259383002/1
4 years, 4 months ago (2016-08-22 16:56:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 18:59:36 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 19:04:12 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79
Cr-Commit-Position: refs/heads/master@{#413496}

Powered by Google App Engine
This is Rietveld 408576698