Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: extensions/browser/updater/extension_downloader.cc

Issue 2259383002: Consistently use namespaced base::Version in extensions code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/runtime/runtime_api.cc ('k') | extensions/browser/updater/update_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/updater/extension_downloader.cc
diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/browser/updater/extension_downloader.cc
index 123fb307acb481a7c7bf88cd1fbbe2b4ebdbcad2..91c08c29e28972c55f7d8d82d540d3869fa3682f 100644
--- a/extensions/browser/updater/extension_downloader.cc
+++ b/extensions/browser/updater/extension_downloader.cc
@@ -151,9 +151,9 @@ bool IncrementAuthUserIndex(GURL* url) {
} // namespace
-UpdateDetails::UpdateDetails(const std::string& id, const Version& version)
- : id(id), version(version) {
-}
+UpdateDetails::UpdateDetails(const std::string& id,
+ const base::Version& version)
+ : id(id), version(version) {}
UpdateDetails::~UpdateDetails() {
}
@@ -228,7 +228,7 @@ bool ExtensionDownloader::AddPendingExtension(const std::string& id,
// Use a zero version to ensure that a pending extension will always
// be updated, and thus installed (assuming all extensions have
// non-zero versions).
- Version version("0.0.0.0");
+ base::Version version("0.0.0.0");
DCHECK(version.IsValid());
return AddExtensionData(id, version, Manifest::TYPE_UNKNOWN, update_url,
@@ -287,7 +287,7 @@ void ExtensionDownloader::set_test_delegate(
}
bool ExtensionDownloader::AddExtensionData(const std::string& id,
- const Version& version,
+ const base::Version& version,
Manifest::Type extension_type,
const GURL& extension_update_url,
const std::string& update_url_data,
@@ -632,8 +632,8 @@ void ExtensionDownloader::DetermineUpdates(
VLOG(2) << id << " is at '" << version << "'";
- Version existing_version(version);
- Version update_version(update->version);
+ base::Version existing_version(version);
+ base::Version update_version(update->version);
if (!update_version.IsValid() ||
update_version.CompareTo(existing_version) <= 0) {
continue;
@@ -850,7 +850,7 @@ void ExtensionDownloader::NotifyExtensionsDownloadFailed(
void ExtensionDownloader::NotifyUpdateFound(const std::string& id,
const std::string& version) {
- UpdateDetails updateInfo(id, Version(version));
+ UpdateDetails updateInfo(id, base::Version(version));
content::NotificationService::current()->Notify(
extensions::NOTIFICATION_EXTENSION_UPDATE_FOUND,
content::NotificationService::AllBrowserContextsAndSources(),
« no previous file with comments | « extensions/browser/api/runtime/runtime_api.cc ('k') | extensions/browser/updater/update_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698