Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 2259383002: Consistently use namespaced base::Version in extensions code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_installer.cc
diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc
index 1178c869b5cd008ed2560ad849021fa68fc17248..adb5e13c7f845e6d88b267f5d075607bfe1b00a8 100644
--- a/chrome/browser/extensions/webstore_installer.cc
+++ b/chrome/browser/extensions/webstore_installer.cc
@@ -414,7 +414,7 @@ void WebstoreInstaller::OnExtensionInstalled(
CHECK_EQ(extension->id(), id_);
ReportSuccess();
} else {
- const Version version_required(info.minimum_version);
+ const base::Version version_required(info.minimum_version);
if (version_required.IsValid() &&
extension->version()->CompareTo(version_required) < 0) {
// It should not happen, CrxInstaller will make sure the version is
@@ -488,11 +488,10 @@ void WebstoreInstaller::OnDownloadStarted(
Approval::CreateForSharedModule(profile_);
const SharedModuleInfo::ImportInfo& info = pending_modules_.front();
approval->extension_id = info.extension_id;
- const Version version_required(info.minimum_version);
+ const base::Version version_required(info.minimum_version);
if (version_required.IsValid()) {
- approval->minimum_version.reset(
- new Version(version_required));
+ approval->minimum_version.reset(new base::Version(version_required));
}
download_item_->SetUserData(kApprovalKey, approval.release());
} else {

Powered by Google App Engine
This is Rietveld 408576698