chrome/browser/extensions/extension_management_internal.cc - Issue 2259383002: Consistently use namespaced base::Version in extensions code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_management_internal.cc

Issue 2259383002: Consistently use namespaced base::Version in extensions code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_extensions_browser_client.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_management_internal.cc

diff --git a/chrome/browser/extensions/extension_management_internal.cc b/chrome/browser/extensions/extension_management_internal.cc

index a472df77ae6872e8d02152f1886c1647ce848edf..5d317f8273d75012140d1b48fe887464ede50c75 100644

--- a/chrome/browser/extensions/extension_management_internal.cc

+++ b/chrome/browser/extensions/extension_management_internal.cc

@@ -138,7 +138,7 @@ bool IndividualSettings::Parse(const base::DictionaryValue* dict,

schema_constants::kMinimumVersionRequired,

&minimum_version_required_str)) {

std::unique_ptr<base::Version> version(

- new Version(minimum_version_required_str));

+ new base::Version(minimum_version_required_str));

// We accept a general version string here. Note that count of components in

// version string of extensions is limited to 4.

if (!version->IsValid())

« no previous file with comments | « chrome/browser/extensions/chrome_extensions_browser_client.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »