chrome/browser/extensions/extension_sync_data.cc - Issue 2259383002: Consistently use namespaced base::Version in extensions code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_sync_data.cc

Issue 2259383002: Consistently use namespaced base::Version in extensions code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_sync_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_sync_data.cc

diff --git a/chrome/browser/extensions/extension_sync_data.cc b/chrome/browser/extensions/extension_sync_data.cc

index b1d203130733be7a50f645691f85bc578ac56ca3..d6d7de18d4e001c54300075cda9003984b188628 100644

--- a/chrome/browser/extensions/extension_sync_data.cc

+++ b/chrome/browser/extensions/extension_sync_data.cc

@@ -241,7 +241,7 @@ bool ExtensionSyncData::PopulateFromExtensionSpecifics(

return false;

}

- Version specifics_version(specifics.version());

+ base::Version specifics_version(specifics.version());

if (!specifics_version.IsValid()) {

LOG(ERROR) << "Attempt to sync bad ExtensionSpecifics (bad version):\n"

<< GetExtensionSpecificsLogMessage(specifics);