extensions/browser/api/runtime/runtime_api.cc - Issue 2259383002: Consistently use namespaced base::Version in extensions code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/runtime/runtime_api.cc

Issue 2259383002: Consistently use namespaced base::Version in extensions code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc ('k') | extensions/browser/updater/extension_downloader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/runtime/runtime_api.cc

diff --git a/extensions/browser/api/runtime/runtime_api.cc b/extensions/browser/api/runtime/runtime_api.cc

index c7e238c44f5f2816facc9a8bea83c88bd3dcc35b..b8f4f3103f28c0b4654c2a63c59f73bbc18e87bc 100644

--- a/extensions/browser/api/runtime/runtime_api.cc

+++ b/extensions/browser/api/runtime/runtime_api.cc

@@ -251,7 +251,7 @@ void RuntimeAPI::OnExtensionLoaded(content::BrowserContext* browser_context,

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(&RuntimeEventRouter::DispatchOnInstalledEvent,

- browser_context_, extension->id(), Version(), true));

+ browser_context_, extension->id(), base::Version(), true));

}

void RuntimeAPI::OnExtensionWillBeInstalled(

@@ -509,7 +509,7 @@ void RuntimeEventRouter::DispatchOnStartupEvent(

void RuntimeEventRouter::DispatchOnInstalledEvent(

content::BrowserContext* context,

const std::string& extension_id,

- const Version& old_version,

+ const base::Version& old_version,

bool chrome_updated) {

if (!ExtensionsBrowserClient::Get()->IsValidContext(context))

return;