chrome/browser/extensions/external_policy_loader_unittest.cc - Issue 2259383002: Consistently use namespaced base::Version in extensions code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_policy_loader_unittest.cc

Issue 2259383002: Consistently use namespaced base::Version in extensions code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_sync_data_unittest.cc ('k') | chrome/browser/extensions/external_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_policy_loader_unittest.cc

diff --git a/chrome/browser/extensions/external_policy_loader_unittest.cc b/chrome/browser/extensions/external_policy_loader_unittest.cc

index 7fd52e00a4e2afb0c106eb37cc17e2a38d61b9dc..9aaae0822babffe5d180861908fea0083cd32f2a 100644

--- a/chrome/browser/extensions/external_policy_loader_unittest.cc

+++ b/chrome/browser/extensions/external_policy_loader_unittest.cc

@@ -85,7 +85,7 @@ class MockExternalPolicyProviderVisitor

// Provider returns the correct location when asked.

Manifest::Location location1;

- std::unique_ptr<Version> version1;

+ std::unique_ptr<base::Version> version1;

provider_->GetExtensionDetails(info.extension_id, &location1, &version1);

EXPECT_EQ(Manifest::EXTERNAL_POLICY_DOWNLOAD, location1);

EXPECT_FALSE(version1.get());

« no previous file with comments | « chrome/browser/extensions/extension_sync_data_unittest.cc ('k') | chrome/browser/extensions/external_provider_impl.cc » ('j') | no next file with comments »