chrome/browser/extensions/chrome_extensions_browser_client.cc - Issue 2259383002: Consistently use namespaced base::Version in extensions code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extensions_browser_client.cc

Issue 2259383002: Consistently use namespaced base::Version in extensions code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc ('k') | chrome/browser/extensions/extension_management_internal.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extensions_browser_client.cc

diff --git a/chrome/browser/extensions/chrome_extensions_browser_client.cc b/chrome/browser/extensions/chrome_extensions_browser_client.cc

index 9836496e6eb9e1c9360c6561e134aeace2ea4b16..47e58818826dca7e42d3d53e6b4edb0bafc330f0 100644

--- a/chrome/browser/extensions/chrome_extensions_browser_client.cc

+++ b/chrome/browser/extensions/chrome_extensions_browser_client.cc

@@ -325,7 +325,7 @@ bool ChromeExtensionsBrowserClient::IsMinBrowserVersionSupported(

const std::string& min_version) {

base::Version browser_version =

base::Version(version_info::GetVersionNumber());

- Version browser_min_version(min_version);

+ base::Version browser_min_version(min_version);

if (browser_version.IsValid() && browser_min_version.IsValid() &&

browser_min_version.CompareTo(browser_version) > 0) {

return false;