extensions/common/manifest_handlers/shared_module_info.cc - Issue 2259383002: Consistently use namespaced base::Version in extensions code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/shared_module_info.cc

Issue 2259383002: Consistently use namespaced base::Version in extensions code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/manifest_handlers/shared_module_info.cc

diff --git a/extensions/common/manifest_handlers/shared_module_info.cc b/extensions/common/manifest_handlers/shared_module_info.cc

index 25679e1f7781705c95e75e57b1d32b2d6b28c16f..b8f62295e05d73d0401f44a7f6fe15eefca30fd9 100644

--- a/extensions/common/manifest_handlers/shared_module_info.cc

+++ b/extensions/common/manifest_handlers/shared_module_info.cc

@@ -187,7 +187,7 @@ bool SharedModuleInfo::Parse(const Extension* extension,

return false;

}

imports_.back().minimum_version = min_version;

- Version v(min_version);

+ base::Version v(min_version);

if (!v.IsValid()) {

*error = ErrorUtils::FormatErrorMessageUTF16(

errors::kInvalidImportVersion, base::SizeTToString(i));

« no previous file with comments | « extensions/common/extension.cc ('k') | extensions/common/update_manifest.cc » ('j') | no next file with comments »