Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2075)

Unified Diff: chrome/browser/extensions/external_provider_impl.cc

Issue 2259383002: Consistently use namespaced base::Version in extensions code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_provider_impl.cc
diff --git a/chrome/browser/extensions/external_provider_impl.cc b/chrome/browser/extensions/external_provider_impl.cc
index 3673d8e6b8a280b5fd022a9aa5c2afb351f195db..c3a50886c1f12d208199d319a39e1147fa86d53a 100644
--- a/chrome/browser/extensions/external_provider_impl.cc
+++ b/chrome/browser/extensions/external_provider_impl.cc
@@ -343,7 +343,8 @@ void ExternalProviderImpl::RetrieveExtensionsFromPrefs(
path = base_path.Append(external_crx);
}
- std::unique_ptr<Version> version(new Version(external_version));
+ std::unique_ptr<base::Version> version(
+ new base::Version(external_version));
if (!version->IsValid()) {
LOG(WARNING) << "Malformed extension dictionary for extension: "
<< extension_id.c_str() << ". Invalid version string \""
@@ -402,7 +403,7 @@ bool ExternalProviderImpl::HasExtension(
bool ExternalProviderImpl::GetExtensionDetails(
const std::string& id,
Manifest::Location* location,
- std::unique_ptr<Version>* version) const {
+ std::unique_ptr<base::Version>* version) const {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
CHECK(prefs_.get());
CHECK(ready_);
@@ -422,7 +423,7 @@ bool ExternalProviderImpl::GetExtensionDetails(
return false;
if (version)
- version->reset(new Version(external_version));
+ version->reset(new base::Version(external_version));
} else {
NOTREACHED(); // Chrome should not allow prefs to get into this state.
@@ -443,9 +444,9 @@ bool ExternalProviderImpl::HandleMinProfileVersion(
if (profile_ &&
extension->GetString(kMinProfileCreatedByVersion,
&min_profile_created_by_version)) {
- Version profile_version(
+ base::Version profile_version(
profile_->GetPrefs()->GetString(prefs::kProfileCreatedByVersion));
- Version min_version(min_profile_created_by_version);
+ base::Version min_version(min_profile_created_by_version);
if (min_version.IsValid() && profile_version.CompareTo(min_version) < 0) {
unsupported_extensions->insert(extension_id);
VLOG(1) << "Skip installing (or uninstall) external extension: "

Powered by Google App Engine
This is Rietveld 408576698