Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 2236583003: Rename AnimationEffect to AnimationEffectReadOnly (Closed)

Created:
4 years, 4 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 4 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@deprecated-assert
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename AnimationEffect to AnimationEffectReadOnly AnimationEffectReadOnly.idl is implemented by the AnimationEffect class. Using a different name is discouraged (see https://www.chromium.org/developers/web-idl-interfaces#TOC-Names) so this patch renames the AnimationEffect class to AnimationEffectReadOnly. BUG=624639 Committed: https://crrev.com/34fecabd35bd9da50ff3498c83ae66c1806c9233 Cr-Commit-Position: refs/heads/master@{#412456}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -1392 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.h View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/animation/AnimationEffect.h View 1 chunk +0 lines, -166 lines 0 comments Download
D third_party/WebKit/Source/core/animation/AnimationEffect.cpp View 1 2 3 1 chunk +0 lines, -241 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.h View 6 chunks +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp View 1 2 3 11 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.idl View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/core/animation/AnimationEffectReadOnlyTest.cpp View 1 2 3 43 chunks +88 lines, -88 lines 0 comments Download
D third_party/WebKit/Source/core/animation/AnimationEffectTest.cpp View 1 2 3 1 chunk +0 lines, -765 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffectTiming.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimations.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InertEffect.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InertEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Keyframe.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectModel.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/TimingCalculations.h View 1 2 3 5 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/animation/TimingCalculationsTest.cpp View 1 2 3 2 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.h View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 7 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (16 generated)
suzyh_UTC10 (ex-contributor)
4 years, 4 months ago (2016-08-11 06:48:11 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 4 months ago (2016-08-11 07:10:22 UTC) #7
suzyh_UTC10 (ex-contributor)
+dgozman for core/core.gypi and core/inspector OWNERS
4 years, 4 months ago (2016-08-16 05:11:00 UTC) #13
dgozman
On 2016/08/16 05:11:00, suzyh wrote: > +dgozman for core/core.gypi and core/inspector OWNERS lgtm
4 years, 4 months ago (2016-08-16 16:59:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236583003/20001
4 years, 4 months ago (2016-08-17 03:15:37 UTC) #17
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-17 03:18:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236583003/60001
4 years, 4 months ago (2016-08-17 03:48:11 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-17 06:06:06 UTC) #23
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 06:07:30 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/34fecabd35bd9da50ff3498c83ae66c1806c9233
Cr-Commit-Position: refs/heads/master@{#412456}

Powered by Google App Engine
This is Rietveld 408576698