third_party/WebKit/Source/core/animation/AnimationStack.cpp - Issue 2236583003: Rename AnimationEffect to AnimationEffectReadOnly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/AnimationStack.cpp

Issue 2236583003: Rename AnimationEffect to AnimationEffectReadOnly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@deprecated-assert

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp ('k') | third_party/WebKit/Source/core/animation/AnimationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/AnimationStack.cpp

diff --git a/third_party/WebKit/Source/core/animation/AnimationStack.cpp b/third_party/WebKit/Source/core/animation/AnimationStack.cpp

index eb3cf6315cac3af0032577edd9293cb9d9efc159..0822a08801e943e5870899f2096e8ac3796c2396 100644

--- a/third_party/WebKit/Source/core/animation/AnimationStack.cpp

+++ b/third_party/WebKit/Source/core/animation/AnimationStack.cpp

@@ -85,7 +85,7 @@ AnimationStack::AnimationStack()

bool AnimationStack::hasActiveAnimationsOnCompositor(CSSPropertyID property) const

{

for (const auto& sampledEffect : m_sampledEffects) {

- // TODO(dstockwell): move the playing check into AnimationEffect and expose both hasAnimations and hasActiveAnimations

+ // TODO(dstockwell): move the playing check into AnimationEffectReadOnly and expose both hasAnimations and hasActiveAnimations

if (sampledEffect->effect() && sampledEffect->effect()->animation()->playing() && sampledEffect->effect()->hasActiveAnimationsOnCompositor(property))

return true;

}