third_party/WebKit/Source/core/animation/KeyframeEffect.cpp - Issue 2236583003: Rename AnimationEffect to AnimationEffectReadOnly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

Issue 2236583003: Rename AnimationEffect to AnimationEffectReadOnly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@deprecated-assert

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffect.h ('k') | third_party/WebKit/Source/core/animation/KeyframeEffectModel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

index f7a4de7b18ef6e6af938c1d095d463608a1b5c7a..e0e76491fb6446edc3317a145a4c2313d8f1366c 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

@@ -85,7 +85,7 @@ KeyframeEffect* KeyframeEffect::create(ExecutionContext* executionContext, Eleme

}

KeyframeEffect::KeyframeEffect(Element* target, EffectModel* model, const Timing& timing, Priority priority, EventDelegate* eventDelegate)

- : AnimationEffect(timing, eventDelegate)

+ : AnimationEffectReadOnly(timing, eventDelegate)

, m_target(target)

, m_model(model)

, m_sampledEffect(nullptr)

@@ -105,7 +105,7 @@ void KeyframeEffect::attach(Animation* animation)

if (RuntimeEnabledFeatures::webAnimationsSVGEnabled() && m_target->isSVGElement())

toSVGElement(m_target)->setWebAnimationsPending();

}

- AnimationEffect::attach(animation);

+ AnimationEffectReadOnly::attach(animation);

}

void KeyframeEffect::detach()

@@ -114,7 +114,7 @@ void KeyframeEffect::detach()

m_target->elementAnimations()->animations().remove(animation());

if (m_sampledEffect)

clearEffects();

- AnimationEffect::detach();

+ AnimationEffectReadOnly::detach();

}

void KeyframeEffect::specifiedTimingChanged()

@@ -366,7 +366,7 @@ DEFINE_TRACE(KeyframeEffect)

visitor->trace(m_target);

visitor->trace(m_model);

visitor->trace(m_sampledEffect);

- AnimationEffect::trace(visitor);

+ AnimationEffectReadOnly::trace(visitor);

}

} // namespace blink