third_party/WebKit/Source/core/animation/AnimationTest.cpp - Issue 2236583003: Rename AnimationEffect to AnimationEffectReadOnly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/AnimationTest.cpp

Issue 2236583003: Rename AnimationEffect to AnimationEffectReadOnly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@deprecated-assert

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationStack.cpp ('k') | third_party/WebKit/Source/core/animation/AnimationTimeline.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/AnimationTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/AnimationTest.cpp b/third_party/WebKit/Source/core/animation/AnimationTest.cpp

index 0b8a59ee703c34896bd6abcf1cf311c28d32c6a1..a0513d9d0caff012e35196d98546a15c5749aa7c 100644

--- a/third_party/WebKit/Source/core/animation/AnimationTest.cpp

+++ b/third_party/WebKit/Source/core/animation/AnimationTest.cpp

@@ -571,8 +571,8 @@ TEST_F(AnimationAnimationTest, SetEffect)

{

animation = timeline->play(0);

animation->setStartTime(0);

- AnimationEffect* effect1 = makeAnimation();

- AnimationEffect* effect2 = makeAnimation();

+ AnimationEffectReadOnly* effect1 = makeAnimation();

+ AnimationEffectReadOnly* effect2 = makeAnimation();

animation->setEffect(effect1);

EXPECT_EQ(effect1, animation->effect());

EXPECT_EQ(0, animation->currentTimeInternal());

@@ -617,7 +617,7 @@ TEST_F(AnimationAnimationTest, EmptyAnimationsDontUpdateEffects)

TEST_F(AnimationAnimationTest, AnimationsDisassociateFromEffect)

{

- AnimationEffect* animationNode = animation->effect();

+ AnimationEffectReadOnly* animationNode = animation->effect();

Animation* animation2 = timeline->play(animationNode);

EXPECT_EQ(0, animation->effect());

animation->setEffect(animationNode);