Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests. (Closed)

Created:
4 years, 4 months ago by Eric Seckler
Modified:
4 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, Peter Beverloo, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, jochen+watch_chromium.org, kozyatinskiy+blink_chromium.org, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes naming issues in Browser protocol handler + adds tests. BUG=546953 Committed: https://crrev.com/90cc74879f8c930171dcc579e5fb65778991fa08 Cr-Commit-Position: refs/heads/master@{#411962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -9 lines) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_discovery/devtools_discovery_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/devtools_discovery/devtools_discovery_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/browser_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 chunk +31 lines, -1 line 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eric Seckler
Fixes to some buggy paths in the Create/GetTarget paths, pulled out of https://codereview.chromium.org/2226323002/
4 years, 4 months ago (2016-08-11 10:54:49 UTC) #5
pfeldman
lgtm, thanks.
4 years, 4 months ago (2016-08-13 00:17:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234343002/60001
4 years, 4 months ago (2016-08-15 12:57:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 4 months ago (2016-08-15 14:14:01 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 14:16:25 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/90cc74879f8c930171dcc579e5fb65778991fa08
Cr-Commit-Position: refs/heads/master@{#411962}

Powered by Google App Engine
This is Rietveld 408576698