Fixes naming issues in Browser protocol handler + adds tests.

content/browser/devtools/protocol/devtools_protocol_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/base64.h"
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
@@ skipping 667 matching lines @@
   TestJavaScriptDialogManager dialog_manager;
   shell()->web_contents()->SetDelegate(&dialog_manager);
   SendCommand("Page.enable", nullptr, true);
   std::unique_ptr<base::DictionaryValue> params(new base::DictionaryValue());
   params->SetString("expression", "alert('alert')");
   SendCommand("Runtime.evaluate", std::move(params), false);
   WaitForNotification("Page.javascriptDialogOpening");
   dialog_manager.Handle();
 }
 
-IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, BrowserCreateTarget) {
+IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, BrowserCreateAndCloseTarget) {
   NavigateToURLBlockUntilNavigationsComplete(shell(), GURL("about:blank"), 1);
   Attach();
   EXPECT_EQ(1u, shell()->windows().size());
   std::unique_ptr<base::DictionaryValue> params(new base::DictionaryValue());
   params->SetString("url", "about:blank");
   SendCommand("Browser.createTarget", std::move(params), true);
+  std::string target_id;
+  EXPECT_TRUE(result_->GetString("targetId", &target_id));
   EXPECT_EQ(2u, shell()->windows().size());
+
+  // TODO(eseckler): Since the RenderView is closed asynchronously, we currently
+  // don't verify that the command actually closes the shell.
+  bool success;
+  params.reset(new base::DictionaryValue());
+  params->SetString("targetId", target_id);
+  SendCommand("Browser.closeTarget", std::move(params), true);
+  EXPECT_TRUE(result_->GetBoolean("success", &success));
+  EXPECT_TRUE(success);
+}
+
+IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, BrowserGetTargets) {
+  NavigateToURLBlockUntilNavigationsComplete(shell(), GURL("about:blank"), 1);
+  Attach();
+  SendCommand("Browser.getTargets", nullptr, true);
+  base::ListValue* target_infos;
+  EXPECT_TRUE(result_->GetList("targetInfo", &target_infos));
+  EXPECT_EQ(1u, target_infos->GetSize());
+  base::DictionaryValue* target_info;
+  EXPECT_TRUE(target_infos->GetDictionary(0u, &target_info));
+  std::string target_id, type, title, url;
+  EXPECT_TRUE(target_info->GetString("targetId", &target_id));
+  EXPECT_TRUE(target_info->GetString("type", &type));
+  EXPECT_TRUE(target_info->GetString("title", &title));
+  EXPECT_TRUE(target_info->GetString("url", &url));
+  EXPECT_EQ(type, "web_contents");
+  EXPECT_EQ(title, "about:blank");
+  EXPECT_EQ(url, "about:blank");
 }
 
 namespace {
 class NavigationFinishedObserver : public content::WebContentsObserver {
  public:
   explicit NavigationFinishedObserver(WebContents* web_contents)
       : WebContentsObserver(web_contents),
         num_finished_(0),
         num_to_wait_for_(0) {}
 
@@ skipping 175 matching lines @@
   params->SetString("policy", "advance");
   params->SetInteger("budget", 1000);
   SendCommand("Emulation.setVirtualTimePolicy", std::move(params), true);
 
   WaitForNotification("Emulation.virtualTimeBudgetExpired");
 
   EXPECT_THAT(console_messages_, ElementsAre("before", "done", "after"));
 }
 
 }  // namespace content