Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/devtools_discovery/devtools_discovery_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/chrome_devtools_manager_delegate.h" 5 #include "chrome/browser/devtools/chrome_devtools_manager_delegate.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/devtools/devtools_network_protocol_handler.h" 8 #include "chrome/browser/devtools/devtools_network_protocol_handler.h"
9 #include "components/devtools_discovery/devtools_discovery_manager.h" 9 #include "components/devtools_discovery/devtools_discovery_manager.h"
10 10
(...skipping 30 matching lines...) Expand all
41 DCHECK(web_contents); 41 DCHECK(web_contents);
42 DevToolsWindow::OpenDevToolsWindow(web_contents); 42 DevToolsWindow::OpenDevToolsWindow(web_contents);
43 } 43 }
44 #endif // !defined(OS_ANDROID) 44 #endif // !defined(OS_ANDROID)
45 } 45 }
46 46
47 base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand( 47 base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand(
48 content::DevToolsAgentHost* agent_host, 48 content::DevToolsAgentHost* agent_host,
49 base::DictionaryValue* command_dict) { 49 base::DictionaryValue* command_dict) {
50 std::unique_ptr<base::DictionaryValue> result = 50 std::unique_ptr<base::DictionaryValue> result =
51 DevToolsDiscoveryManager::GetInstance()->HandleNewTargetCommand( 51 DevToolsDiscoveryManager::GetInstance()->HandleCreateTargetCommand(
52 command_dict); 52 command_dict);
53 if (result) 53 if (result)
54 return result.release(); // Caller takes ownership. 54 return result.release(); // Caller takes ownership.
55 return network_protocol_handler_->HandleCommand(agent_host, command_dict); 55 return network_protocol_handler_->HandleCommand(agent_host, command_dict);
56 } 56 }
57 57
58 void ChromeDevToolsManagerDelegate::DevToolsAgentStateChanged( 58 void ChromeDevToolsManagerDelegate::DevToolsAgentStateChanged(
59 content::DevToolsAgentHost* agent_host, 59 content::DevToolsAgentHost* agent_host,
60 bool attached) { 60 bool attached) {
61 network_protocol_handler_->DevToolsAgentStateChanged(agent_host, attached); 61 network_protocol_handler_->DevToolsAgentStateChanged(agent_host, attached);
62 } 62 }
OLDNEW
« no previous file with comments | « no previous file | components/devtools_discovery/devtools_discovery_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698