content/shell/browser/shell_devtools_manager_delegate.cc - Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_manager_delegate.cc

Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_browsertest.cc ('k') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_devtools_manager_delegate.cc

diff --git a/content/shell/browser/shell_devtools_manager_delegate.cc b/content/shell/browser/shell_devtools_manager_delegate.cc

index 9361e9a53cab2b5a3563dd93e23c3bb3ec5fe640..b3746c37f7008a30aa3f243b1dcf2007745c18b7 100644

--- a/content/shell/browser/shell_devtools_manager_delegate.cc

+++ b/content/shell/browser/shell_devtools_manager_delegate.cc

@@ -232,7 +232,7 @@ base::DictionaryValue* ShellDevToolsManagerDelegate::HandleCommand(

base::DictionaryValue* command_dict) {

std::unique_ptr<base::DictionaryValue> result =

devtools_discovery::DevToolsDiscoveryManager::GetInstance()

- ->HandleNewTargetCommand(command_dict);

+ ->HandleCreateTargetCommand(command_dict);

return result.release(); // Caller takes ownership.

}