components/devtools_discovery/devtools_discovery_manager.h - Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_discovery/devtools_discovery_manager.h

Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/chrome_devtools_manager_delegate.cc ('k') | components/devtools_discovery/devtools_discovery_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_discovery/devtools_discovery_manager.h

diff --git a/components/devtools_discovery/devtools_discovery_manager.h b/components/devtools_discovery/devtools_discovery_manager.h

index 023e067a035e7993ee9499343e765130ae8a8dd7..2e1eb06d98516985fe6ab08bce2ac1803c79ab38 100644

--- a/components/devtools_discovery/devtools_discovery_manager.h

+++ b/components/devtools_discovery/devtools_discovery_manager.h

@@ -40,8 +40,8 @@ class DevToolsDiscoveryManager {

DevToolsTargetDescriptor::List GetDescriptors();

std::unique_ptr<DevToolsTargetDescriptor> CreateNew(const GURL& url);

- // Handles Browser.newPage only.

- std::unique_ptr<base::DictionaryValue> HandleNewTargetCommand(

+ // Handles Browser.createTarget only.

+ std::unique_ptr<base::DictionaryValue> HandleCreateTargetCommand(

base::DictionaryValue* command_dict);

private: