content/browser/devtools/protocol/browser_handler.cc - Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/browser_handler.cc

Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/devtools_discovery/devtools_discovery_manager.cc ('k') | content/browser/devtools/protocol/devtools_protocol_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/browser_handler.cc

diff --git a/content/browser/devtools/protocol/browser_handler.cc b/content/browser/devtools/protocol/browser_handler.cc

index be31b84ce8a8cc9629b6442953fda0884184a84b..5f0634bdb9c034c3ac484efaf4ef5910edea0e10 100644

--- a/content/browser/devtools/protocol/browser_handler.cc

+++ b/content/browser/devtools/protocol/browser_handler.cc

@@ -87,6 +87,7 @@ Response BrowserHandler::GetTargets(TargetInfos* infos) {

set_type(GetTypeString(agent_host))->

set_title(agent_host->GetTitle())->

set_url(agent_host->GetURL().spec());

+ infos->push_back(info);

}

return Response::OK();

}