Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/browser/shell_devtools_manager_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index d4421424d10881a3da18992ade69f5798072a1be..df772634d314233ee5bf96e6c19794aef23e9fde 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -4319,8 +4319,8 @@
"description": "Creates a new page.",
"parameters": [
{ "name": "url", "type": "string", "description": "The initial URL the page will be navigated to." },
- { "name": "width", "type": "integer", "description": "Window width (headless chrome only).", "optional": true },
- { "name": "height", "type": "integer", "description": "Window height (headless chrome only).", "optional": true },
+ { "name": "width", "type": "integer", "description": "Frame width in DIP (headless chrome only).", "optional": true },
+ { "name": "height", "type": "integer", "description": "Frame height in DIP (headless chrome only).", "optional": true },
{ "name": "browserContextId", "$ref": "BrowserContextID", "description": "The browser context to create the page in (headless chrome only).", "optional": true }
],
"returns": [
« no previous file with comments | « content/shell/browser/shell_devtools_manager_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698