chrome/browser/devtools/chrome_devtools_manager_delegate.cc - Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc

index 9d61e1160f59ffad3c0a723481ab05d40efa1a75..307f2bac8cd76690b49cb5aff6e11bc6d090130c 100644

--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc

+++ b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc

@@ -48,7 +48,7 @@ base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand(

content::DevToolsAgentHost* agent_host,

base::DictionaryValue* command_dict) {

std::unique_ptr<base::DictionaryValue> result =

- DevToolsDiscoveryManager::GetInstance()->HandleNewTargetCommand(

+ DevToolsDiscoveryManager::GetInstance()->HandleCreateTargetCommand(

command_dict);

if (result)

return result.release(); // Caller takes ownership.

« no previous file with comments | « no previous file | components/devtools_discovery/devtools_discovery_manager.h » ('j') | no next file with comments »