Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Side by Side Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/shell/browser/shell_devtools_manager_delegate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 "version": { "major": "1", "minor": "1" }, 2 "version": { "major": "1", "minor": "1" },
3 "domains": [{ 3 "domains": [{
4 "domain": "Inspector", 4 "domain": "Inspector",
5 "hidden": true, 5 "hidden": true,
6 "types": [], 6 "types": [],
7 "commands": [ 7 "commands": [
8 { 8 {
9 "name": "enable", 9 "name": "enable",
10 "description": "Enables inspector domain notifications.", 10 "description": "Enables inspector domain notifications.",
(...skipping 4301 matching lines...) Expand 10 before | Expand all | Expand 10 after
4312 "returns": [ 4312 "returns": [
4313 { "name": "success", "type": "boolean" } 4313 { "name": "success", "type": "boolean" }
4314 ], 4314 ],
4315 "handlers": ["browser"] 4315 "handlers": ["browser"]
4316 }, 4316 },
4317 { 4317 {
4318 "name": "createTarget", 4318 "name": "createTarget",
4319 "description": "Creates a new page.", 4319 "description": "Creates a new page.",
4320 "parameters": [ 4320 "parameters": [
4321 { "name": "url", "type": "string", "description": "The initi al URL the page will be navigated to." }, 4321 { "name": "url", "type": "string", "description": "The initi al URL the page will be navigated to." },
4322 { "name": "width", "type": "integer", "description": "Window width (headless chrome only).", "optional": true }, 4322 { "name": "width", "type": "integer", "description": "Frame width in DIP (headless chrome only).", "optional": true },
4323 { "name": "height", "type": "integer", "description": "Windo w height (headless chrome only).", "optional": true }, 4323 { "name": "height", "type": "integer", "description": "Frame height in DIP (headless chrome only).", "optional": true },
4324 { "name": "browserContextId", "$ref": "BrowserContextID", "d escription": "The browser context to create the page in (headless chrome only)." , "optional": true } 4324 { "name": "browserContextId", "$ref": "BrowserContextID", "d escription": "The browser context to create the page in (headless chrome only)." , "optional": true }
4325 ], 4325 ],
4326 "returns": [ 4326 "returns": [
4327 { "name": "targetId", "$ref": "TargetID", "description": "Th e id of the page opened." } 4327 { "name": "targetId", "$ref": "TargetID", "description": "Th e id of the page opened." }
4328 ], 4328 ],
4329 "handlers": ["browser"] 4329 "handlers": ["browser"]
4330 }, 4330 },
4331 { 4331 {
4332 "name": "closeTarget", 4332 "name": "closeTarget",
4333 "description": "Closes the target. If the target is a page that gets closed too.", 4333 "description": "Closes the target. If the target is a page that gets closed too.",
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
4457 "description": "Informs that port was successfully bound and got a specified connection id.", 4457 "description": "Informs that port was successfully bound and got a specified connection id.",
4458 "parameters": [ 4458 "parameters": [
4459 {"name": "port", "type": "integer", "description": "Port num ber that was successfully bound." }, 4459 {"name": "port", "type": "integer", "description": "Port num ber that was successfully bound." },
4460 {"name": "connectionId", "type": "string", "description": "C onnection id to be used." } 4460 {"name": "connectionId", "type": "string", "description": "C onnection id to be used." }
4461 ], 4461 ],
4462 "handlers": ["browser"] 4462 "handlers": ["browser"]
4463 } 4463 }
4464 ] 4464 ]
4465 }] 4465 }]
4466 } 4466 }
OLDNEW
« no previous file with comments | « content/shell/browser/shell_devtools_manager_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698