Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: components/devtools_discovery/devtools_discovery_manager.cc

Issue 2234343002: Fixes naming issues in Browser protocol handler + adds tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/devtools_discovery/devtools_discovery_manager.cc
diff --git a/components/devtools_discovery/devtools_discovery_manager.cc b/components/devtools_discovery/devtools_discovery_manager.cc
index 3c472fa7bfbc1c9894db48d653a24086ca079d89..58f42a7415aa870c714571fa4e0ce3af7b091e9f 100644
--- a/components/devtools_discovery/devtools_discovery_manager.cc
+++ b/components/devtools_discovery/devtools_discovery_manager.cc
@@ -63,7 +63,7 @@ DevToolsDiscoveryManager::GetDescriptorsFromProviders() {
}
std::unique_ptr<base::DictionaryValue>
-DevToolsDiscoveryManager::HandleNewTargetCommand(
+DevToolsDiscoveryManager::HandleCreateTargetCommand(
base::DictionaryValue* command_dict) {
int id;
std::string method;
@@ -82,7 +82,7 @@ DevToolsDiscoveryManager::HandleNewTargetCommand(
result->SetInteger("id", id);
std::unique_ptr<base::DictionaryValue> cmd_result(
new base::DictionaryValue());
- cmd_result->SetString("pageId", descriptor->GetId());
+ cmd_result->SetString("targetId", descriptor->GetId());
result->Set("result", std::move(cmd_result));
return result;
}
« no previous file with comments | « components/devtools_discovery/devtools_discovery_manager.h ('k') | content/browser/devtools/protocol/browser_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698