[recipes] Remove build environment vars from default_env

[recipes] Remove build environment vars from default_env

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002

Committed: https://skia.googlesource.com/skia/+/d460a3c256d9bd4a9f4df49b065f887ec35914c1

[borenet2, 2016-08-04 17:07:25]

Description was changed from

==========
[recipes] Remove build environment vars from default_env

BUG=skia:5578
==========

to

==========
[recipes] Remove build environment vars from default_env

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002
==========

[borenet, 2016-08-04 18:51:33]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@google.com

[rmistry, 2016-08-04 20:02:58]

https://codereview.chromium.org/2209423002/diff/20001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/flavor/api.py (right):

https://codereview.chromium.org/2209423002/diff/20001/infra/bots/recipe_modul...
infra/bots/recipe_modules/flavor/api.py:92: def compile(self, target, **kwargs):
Why not have compile explicitly take in an env parameter so you do not have to
pop it out of kwargs in some places.

[borenet, 2016-08-05 11:41:05]

https://codereview.chromium.org/2209423002/diff/20001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/flavor/api.py (right):

https://codereview.chromium.org/2209423002/diff/20001/infra/bots/recipe_modul...
infra/bots/recipe_modules/flavor/api.py:92: def compile(self, target, **kwargs):
On 2016/08/04 20:02:58, rmistry wrote:
> Why not have compile explicitly take in an env parameter so you do not have to
> pop it out of kwargs in some places.

It seemed easier to provide plumbing for arbitrary things in the future.  I can
change if you'd really prefer it.

[rmistry, 2016-08-05 11:45:04]

lgtm

https://codereview.chromium.org/2209423002/diff/20001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/flavor/api.py (right):

https://codereview.chromium.org/2209423002/diff/20001/infra/bots/recipe_modul...
infra/bots/recipe_modules/flavor/api.py:92: def compile(self, target, **kwargs):
On 2016/08/05 11:41:05, borenet wrote:
> On 2016/08/04 20:02:58, rmistry wrote:
> > Why not have compile explicitly take in an env parameter so you do not have
to
> > pop it out of kwargs in some places.
> 
> It seemed easier to provide plumbing for arbitrary things in the future.  I
can
> change if you'd really prefer it.

No, leaving it up to you. My thinking was that it seems to be making assumptions
about what it is called in kwargs by callers but if you have an explicit
parameter then you know exactly what 'env' is. As is works for me as well.

[borenet, 2016-08-05 11:55:22]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-08-05 11:55:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 12:18:13]

Description was changed from

==========
[recipes] Remove build environment vars from default_env

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002
==========

to

==========
[recipes] Remove build environment vars from default_env

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002

Committed:
https://skia.googlesource.com/skia/+/d460a3c256d9bd4a9f4df49b065f887ec35914c1
==========

[commit-bot: I haz the power, 2016-08-05 12:18:14]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d460a3c256d9bd4a9f4df49b065f887ec35914c1