[recipes] Remove build environment vars from default_env

infra/bots/recipe_modules/flavor/api.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 # pylint: disable=W0201
 
 
 from recipe_engine import recipe_api
 
@@ skipping 71 matching lines @@
       return coverage_flavor.CoverageFlavorUtils(self.m)
     else:
       return default_flavor.DefaultFlavorUtils(self.m)
 
   def setup(self):
     self._f = self.get_flavor(self.m.vars.builder_cfg)
 
   def step(self, name, cmd, **kwargs):
     return self._f.step(name, cmd, **kwargs)
 
-  def compile(self, target):
-    return self._f.compile(target)
+  def compile(self, target, **kwargs):

[rmistry, 2016/08/04 20:02:58]

Why not have compile explicitly take in an env parameter so you do not have to
pop it out of kwargs in some places.

[borenet, 2016/08/05 11:41:05]

It seemed easier to provide plumbing for arbitrary things in the future.  I can
change if you'd really prefer it.

[rmistry, 2016/08/05 11:45:04]

No, leaving it up to you. My thinking was that it seems to be making assumptions
about what it is called in kwargs by callers but if you have an explicit
parameter then you know exactly what 'env' is. As is works for me as well.

+    return self._f.compile(target, **kwargs)
 
   def copy_extra_build_products(self, swarming_out_dir):
     return self._f.copy_extra_build_products(swarming_out_dir)
 
   @property
   def out_dir(self):
     return self._f.out_dir
 
   def device_path_join(self, *args):
     return self._f.device_path_join(*args)
@@ skipping 103 matching lines @@
         version,
         VERSION_FILE_SKP,
         self.m.vars.tmp_dir,
         self.m.vars.local_skp_dir,
         self.device_dirs.skp_dir,
         test_expected_version=self.m.properties.get(
             'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION),
         test_actual_version=self.m.properties.get(
             'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION))
     return version