infra/bots/recipe_modules/vars/api.py - Issue 2209423002: [recipes] Remove build environment vars from default_env

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipe_modules/vars/api.py

Issue 2209423002: [recipes] Remove build environment vars from default_env (Closed) Base URL: https://skia.googlesource.com/skia.git@merge_buildbot_spec_fix_coverage

Patch Set: [recipes] Remove build environment vars from default_env Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« infra/bots/recipe_modules/flavor/api.py ('K') | « infra/bots/recipe_modules/flavor/xsan_flavor.py ('k') | infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: infra/bots/recipe_modules/vars/api.py

diff --git a/infra/bots/recipe_modules/vars/api.py b/infra/bots/recipe_modules/vars/api.py

index 092c3e62b7184409eda510f85f5cd236d7c583b3..c922bf1f238bc0f3f027deb2dbeb0672cef5245b 100644

--- a/infra/bots/recipe_modules/vars/api.py

+++ b/infra/bots/recipe_modules/vars/api.py

@@ -787,8 +787,6 @@ class SkiaVarsApi(recipe_api.RecipeApi):

self.configuration = self.builder_spec['configuration']

self.default_env.update({'SKIA_OUT': self.skia_out,

'BUILDTYPE': self.configuration})

- self.default_env.update(self.builder_spec['env'])

- self.build_targets = [str(t) for t in self.builder_spec['build_targets']]

self.do_compile_steps = self.builder_spec.get('do_compile_steps', True)

self.do_test_steps = self.builder_spec['do_test_steps']

self.do_perf_steps = self.builder_spec['do_perf_steps']

@@ -806,5 +804,3 @@ class SkiaVarsApi(recipe_api.RecipeApi):

self.swarming_out_dir, 'dm')

self.perf_data_dir = self.m.path.join(self.swarming_out_dir,

'perfdata', self.builder_name, 'data')

- self.dm_flags = self.builder_spec['dm_flags']

- self.nanobench_flags = self.builder_spec['nanobench_flags']