Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: infra/bots/recipe_modules/flavor/cmake_flavor.py

Issue 2209423002: [recipes] Remove build environment vars from default_env (Closed) Base URL: https://skia.googlesource.com/skia.git@merge_buildbot_spec_fix_coverage
Patch Set: [recipes] Remove build environment vars from default_env Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipe_modules/flavor/cmake_flavor.py
diff --git a/infra/bots/recipe_modules/flavor/cmake_flavor.py b/infra/bots/recipe_modules/flavor/cmake_flavor.py
index 8b254eceb72e8968f7b3cbd82415a7d7ca57df05..5a127dff52688713ac0fd61c42e18493aa8b4a55 100644
--- a/infra/bots/recipe_modules/flavor/cmake_flavor.py
+++ b/infra/bots/recipe_modules/flavor/cmake_flavor.py
@@ -7,8 +7,8 @@ import default_flavor
"""CMake flavor utils, used for building Skia with CMake."""
class CMakeFlavorUtils(default_flavor.DefaultFlavorUtils):
- def compile(self, target):
+ def compile(self, target, **kwargs):
"""Build Skia with CMake. Ignores `target`."""
cmake_build = self.m.vars.skia_dir.join('cmake', 'cmake_build')
self.m.run(self.m.step, 'cmake_build', cmd=[cmake_build],
- cwd=self.m.path['checkout'])
+ cwd=self.m.path['checkout'], **kwargs)

Powered by Google App Engine
This is Rietveld 408576698