infra/bots/recipes/swarm_compile.py - Issue 2209423002: [recipes] Remove build environment vars from default_env

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipes/swarm_compile.py

Issue 2209423002: [recipes] Remove build environment vars from default_env (Closed) Base URL: https://skia.googlesource.com/skia.git@merge_buildbot_spec_fix_coverage

Patch Set: [recipes] Remove build environment vars from default_env Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« infra/bots/recipe_modules/flavor/api.py ('K') | « infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json ('k') | infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-Arm7-Debug-Android.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: infra/bots/recipes/swarm_compile.py

diff --git a/infra/bots/recipes/swarm_compile.py b/infra/bots/recipes/swarm_compile.py

index 09fb1f62bc4b6c1fc00e872a2db0ccc1fb95b0f5..bb592563af29afb3e0401ddee72784b58c076a3d 100644

--- a/infra/bots/recipes/swarm_compile.py

+++ b/infra/bots/recipes/swarm_compile.py

@@ -48,9 +48,13 @@ TEST_BUILDERS = {

def RunSteps(api):

api.core.setup()

+ env = api.vars.builder_spec['env']

+ build_targets = api.vars.builder_spec['build_targets']

try:

- for target in api.vars.build_targets:

- api.flavor.compile(target)

+ for target in build_targets:

+ api.flavor.compile(target, env=env)

api.run.copy_build_products(

api.flavor.out_dir,

api.vars.swarming_out_dir.join(