infra/bots/recipes/swarm_test.py - Issue 2209423002: [recipes] Remove build environment vars from default_env

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipes/swarm_test.py

Issue 2209423002: [recipes] Remove build environment vars from default_env (Closed) Base URL: https://skia.googlesource.com/skia.git@merge_buildbot_spec_fix_coverage

Patch Set: [recipes] Remove build environment vars from default_env Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« infra/bots/recipe_modules/flavor/api.py ('K') | « infra/bots/recipes/swarm_perf.expected/big_issue_number.json ('k') | infra/bots/recipes/swarm_test.expected/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: infra/bots/recipes/swarm_test.py

diff --git a/infra/bots/recipes/swarm_test.py b/infra/bots/recipes/swarm_test.py

index e219e72cee9209633a688030f01e29f2211a422c..2324140462137ff44ec320f5c97a7f982919779a 100644

--- a/infra/bots/recipes/swarm_test.py

+++ b/infra/bots/recipes/swarm_test.py

@@ -163,11 +163,11 @@ def test_steps(api):

skip_flag = '--nocpu'

if skip_flag:

args.append(skip_flag)

- args.extend(api.vars.dm_flags)

+ args.extend(api.vars.builder_spec['dm_flags'])

api.run(api.flavor.step, 'dm', cmd=args,

- abort_on_failure=False,

- env=api.vars.default_env)

+ abort_on_failure=False,

+ env=api.vars.default_env)

if api.vars.upload_dm_results:

# Copy images and JSON to host machine if needed.