Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: infra/bots/recipe_modules/vars/api.py

Issue 2209423002: [recipes] Remove build environment vars from default_env (Closed) Base URL: https://skia.googlesource.com/skia.git@merge_buildbot_spec_fix_coverage
Patch Set: [recipes] Remove build environment vars from default_env Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 # pylint: disable=W0201 6 # pylint: disable=W0201
7 7
8 8
9 from recipe_engine import recipe_api 9 from recipe_engine import recipe_api
10 import os 10 import os
(...skipping 769 matching lines...) Expand 10 before | Expand all | Expand 10 after
780 780
781 # Obtain the spec for this builder. Use it to set more properties. 781 # Obtain the spec for this builder. Use it to set more properties.
782 self.builder_spec = get_builder_spec(self.m, self.builder_name) 782 self.builder_spec = get_builder_spec(self.m, self.builder_name)
783 783
784 self.builder_cfg = self.builder_spec['builder_cfg'] 784 self.builder_cfg = self.builder_spec['builder_cfg']
785 self.role = self.builder_cfg['role'] 785 self.role = self.builder_cfg['role']
786 786
787 self.configuration = self.builder_spec['configuration'] 787 self.configuration = self.builder_spec['configuration']
788 self.default_env.update({'SKIA_OUT': self.skia_out, 788 self.default_env.update({'SKIA_OUT': self.skia_out,
789 'BUILDTYPE': self.configuration}) 789 'BUILDTYPE': self.configuration})
790 self.default_env.update(self.builder_spec['env'])
791 self.build_targets = [str(t) for t in self.builder_spec['build_targets']]
792 self.do_compile_steps = self.builder_spec.get('do_compile_steps', True) 790 self.do_compile_steps = self.builder_spec.get('do_compile_steps', True)
793 self.do_test_steps = self.builder_spec['do_test_steps'] 791 self.do_test_steps = self.builder_spec['do_test_steps']
794 self.do_perf_steps = self.builder_spec['do_perf_steps'] 792 self.do_perf_steps = self.builder_spec['do_perf_steps']
795 self.is_trybot = self.builder_cfg['is_trybot'] 793 self.is_trybot = self.builder_cfg['is_trybot']
796 self.issue = None 794 self.issue = None
797 self.patchset = None 795 self.patchset = None
798 self.rietveld = None 796 self.rietveld = None
799 if self.is_trybot: 797 if self.is_trybot:
800 self.issue = self.m.properties['issue'] 798 self.issue = self.m.properties['issue']
801 self.patchset = self.m.properties['patchset'] 799 self.patchset = self.m.properties['patchset']
802 self.rietveld = self.m.properties['rietveld'] 800 self.rietveld = self.m.properties['rietveld']
803 self.upload_dm_results = self.builder_spec['upload_dm_results'] 801 self.upload_dm_results = self.builder_spec['upload_dm_results']
804 self.upload_perf_results = self.builder_spec['upload_perf_results'] 802 self.upload_perf_results = self.builder_spec['upload_perf_results']
805 self.dm_dir = self.m.path.join( 803 self.dm_dir = self.m.path.join(
806 self.swarming_out_dir, 'dm') 804 self.swarming_out_dir, 'dm')
807 self.perf_data_dir = self.m.path.join(self.swarming_out_dir, 805 self.perf_data_dir = self.m.path.join(self.swarming_out_dir,
808 'perfdata', self.builder_name, 'data') 806 'perfdata', self.builder_name, 'data')
809 self.dm_flags = self.builder_spec['dm_flags']
810 self.nanobench_flags = self.builder_spec['nanobench_flags']
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698