[recipes] Remove build environment vars from default_env

infra/bots/recipe_modules/flavor/api.py

Index: infra/bots/recipe_modules/flavor/api.py
diff --git a/infra/bots/recipe_modules/flavor/api.py b/infra/bots/recipe_modules/flavor/api.py
index 84bc8999093ffdfc55e1bf4e6505383144a8768e..62730b80dd19dbf3f5044e76a3f6e6c517823772 100644
--- a/infra/bots/recipe_modules/flavor/api.py
+++ b/infra/bots/recipe_modules/flavor/api.py
@@ -89,8 +89,8 @@ class SkiaFlavorApi(recipe_api.RecipeApi):
   def step(self, name, cmd, **kwargs):
     return self._f.step(name, cmd, **kwargs)
 
-  def compile(self, target):
-    return self._f.compile(target)
+  def compile(self, target, **kwargs):

[rmistry, 2016/08/04 20:02:58]

Why not have compile explicitly take in an env parameter so you do not have to
pop it out of kwargs in some places.

[borenet, 2016/08/05 11:41:05]

It seemed easier to provide plumbing for arbitrary things in the future.  I can
change if you'd really prefer it.

[rmistry, 2016/08/05 11:45:04]

No, leaving it up to you. My thinking was that it seems to be making assumptions
about what it is called in kwargs by callers but if you have an explicit
parameter then you know exactly what 'env' is. As is works for me as well.

+    return self._f.compile(target, **kwargs)
 
   def copy_extra_build_products(self, swarming_out_dir):
     return self._f.copy_extra_build_products(swarming_out_dir)