infra/bots/recipe_modules/flavor/ios_flavor.py - Issue 2209423002: [recipes] Remove build environment vars from default_env

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipe_modules/flavor/ios_flavor.py

Issue 2209423002: [recipes] Remove build environment vars from default_env (Closed) Base URL: https://skia.googlesource.com/skia.git@merge_buildbot_spec_fix_coverage

Patch Set: [recipes] Remove build environment vars from default_env Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« infra/bots/recipe_modules/flavor/api.py ('K') | « infra/bots/recipe_modules/flavor/gn_flavor.py ('k') | infra/bots/recipe_modules/flavor/pdfium_flavor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: infra/bots/recipe_modules/flavor/ios_flavor.py

diff --git a/infra/bots/recipe_modules/flavor/ios_flavor.py b/infra/bots/recipe_modules/flavor/ios_flavor.py

index d0d60f428442e0af91fc5887f871e1e65b278f5c..d59b248912ba78a5c8d3d240b559fe48b29a4c17 100644

--- a/infra/bots/recipe_modules/flavor/ios_flavor.py

+++ b/infra/bots/recipe_modules/flavor/ios_flavor.py

@@ -35,11 +35,11 @@ class iOSFlavorUtils(default_flavor.DefaultFlavorUtils):

return self.m.run(self.m.step, name=name, cmd=args + cmd,

env=env, **kwargs)

- def compile(self, target):

+ def compile(self, target, **kwargs):

"""Build the given target."""

cmd = [self.ios_bin.join('ios_ninja')]

self.m.run(self.m.step, 'build iOSShell', cmd=cmd,

- cwd=self.m.path['checkout'])

+ cwd=self.m.path['checkout'], **kwargs)

def device_path_join(self, *args):

"""Like os.path.join(), but for paths on a connected iOS device."""

« infra/bots/recipe_modules/flavor/api.py ('K') | « infra/bots/recipe_modules/flavor/gn_flavor.py ('k') | infra/bots/recipe_modules/flavor/pdfium_flavor.py » ('j') | no next file with comments »