[recipes] Fixes for Coverage bot

[recipes] Fixes for Coverage bot

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002

Committed: https://skia.googlesource.com/skia/+/3f5a47599b8815898780a536e3b195d9f7fc8f82

[borenet2, 2016-08-04 16:11:45]

Description was changed from

==========
[recipes] Fix Coverage bot: separate build and test steps

BUG=skia:5578
==========

to

==========
[recipes] Fix Coverage bot: separate build and test steps

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002
==========

[borenet, 2016-08-04 17:26:41]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@google.com

[borenet, 2016-08-04 17:26:42]

Pending successful trybot...

[rmistry, 2016-08-04 17:40:27]

lgtm

[borenet, 2016-08-04 18:35:24]

Description was changed from

==========
[recipes] Fix Coverage bot: separate build and test steps

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002
==========

to

==========
[recipes] Fixes for Coverage bot

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002
==========

[borenet, 2016-08-04 18:36:42]

Okay, turns out I'd forgotten that the compile and test steps on the coverage
bot are pretty tightly coupled.  There may be a way to separate them but it'll
be a rabbit hole I don't want to enter at the moment.  Instead, just fixed the
environment issues by explicitly putting the compile env in the flavor module.

[borenet, 2016-08-04 18:38:10]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 18:38:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-08-04 18:44:36]

On 2016/08/04 18:36:42, borenet wrote:
> Okay, turns out I'd forgotten that the compile and test steps on the coverage
> bot are pretty tightly coupled.  There may be a way to separate them but it'll
> be a rabbit hole I don't want to enter at the moment.  Instead, just fixed the
> environment issues by explicitly putting the compile env in the flavor module.

No one's made much use of this bot... you may consider a mercy kill if it holds
you back.

[rmistry, 2016-08-04 18:45:25]

On 2016/08/04 18:36:42, borenet wrote:
> Okay, turns out I'd forgotten that the compile and test steps on the coverage
> bot are pretty tightly coupled.  There may be a way to separate them but it'll
> be a rabbit hole I don't want to enter at the moment.  Instead, just fixed the
> environment issues by explicitly putting the compile env in the flavor module.

Yea, IIRC there was a path compiled into the binary.

[borenet, 2016-08-04 18:47:15]

On 2016/08/04 18:44:36, mtklein wrote:
> On 2016/08/04 18:36:42, borenet wrote:
> > Okay, turns out I'd forgotten that the compile and test steps on the
coverage
> > bot are pretty tightly coupled.  There may be a way to separate them but
it'll
> > be a rabbit hole I don't want to enter at the moment.  Instead, just fixed
the
> > environment issues by explicitly putting the compile env in the flavor
module.
> 
> No one's made much use of this bot... you may consider a mercy kill if it
holds
> you back.

I'm satisfied with my hack for now, but will keep it in mind for later.

On 2016/08/04 18:45:25, rmistry wrote:
> On 2016/08/04 18:36:42, borenet wrote:
> > Okay, turns out I'd forgotten that the compile and test steps on the
coverage
> > bot are pretty tightly coupled.  There may be a way to separate them but
it'll
> > be a rabbit hole I don't want to enter at the moment.  Instead, just fixed
the
> > environment issues by explicitly putting the compile env in the flavor
module.
> 
> Yea, IIRC there was a path compiled into the binary.

An absolute path, no less!

[commit-bot: I haz the power, 2016-08-04 19:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 19:07:20]

Dry run: This issue passed the CQ dry run.

[borenet, 2016-08-04 19:15:04]

The CQ bit was checked by borenet@google.com

[borenet, 2016-08-04 19:15:04]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/2217523002/#ps60001
(title: "Fix compile env")

[commit-bot: I haz the power, 2016-08-04 19:15:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 19:16:05]

Description was changed from

==========
[recipes] Fixes for Coverage bot

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002
==========

to

==========
[recipes] Fixes for Coverage bot

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002

Committed:
https://skia.googlesource.com/skia/+/3f5a47599b8815898780a536e3b195d9f7fc8f82
==========

[commit-bot: I haz the power, 2016-08-04 19:16:06]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3f5a47599b8815898780a536e3b195d9f7fc8f82