Remove v8CallOrCrash

Remove v8CallOrCrash

Per the discussion in https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/vGLGCaMqhCU/discussion,
this CL replaces v8CallOrCrash with ToLocalChecked/ToChecked.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/6526c5b4ac92c26c3903146941ceb267422ebf8c
Cr-Commit-Position: refs/heads/master@{#409497}

[haraken, 2016-08-03 08:24:28]

Description was changed from

==========
Remove v8CallOrCrash

Per the discussion in
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/vG...,
this CL replaces v8CallOrCrash with ToLocalChecked/ToChecked.

BUG=
==========

to

==========
Remove v8CallOrCrash

Per the discussion in
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/vG...,
this CL replaces v8CallOrCrash with ToLocalChecked/ToChecked.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[haraken, 2016-08-03 08:24:47]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2016-08-03 08:24:48]

PTAL

[haraken, 2016-08-03 08:24:53]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 08:25:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 08:26:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 08:26:52]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Yuki, 2016-08-03 08:27:31]

lgtm

[haraken, 2016-08-03 08:32:28]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-08-03 08:32:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2200303003/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2016-08-03 08:32:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-08-03 09:02:12]

haraken@chromium.org changed reviewers:
+ nhiroki@chromium.org, yhirano@chromium.org

[haraken, 2016-08-03 09:02:12]

+yhirano +nhiroki: One question below.

https://codereview.chromium.org/2200303003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp
(right):

https://codereview.chromium.org/2200303003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp:41: if
(isTerminating(scriptState))

yhirano@, nhiroki@: Now that nhiroki@ removed the force termination from worker
threads, can we remove these isTerminating() checks? Or do we still need them?

[yhirano, 2016-08-03 09:07:37]

https://codereview.chromium.org/2200303003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp
(right):

https://codereview.chromium.org/2200303003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp:41: if
(isTerminating(scriptState))
On 2016/08/03 09:02:12, haraken wrote:
> 
> yhirano@, nhiroki@: Now that nhiroki@ removed the force termination from
worker
> threads, can we remove these isTerminating() checks? Or do we still need them?

We don't need them. I haven't done modules/fetch and core/streams cleanup in
order to keep the code easy to merge, but I will do the cleanup soon as the
shipped feature is becoming stable recently.

[haraken, 2016-08-03 09:10:46]

On 2016/08/03 09:07:37, yhirano wrote:
>
https://codereview.chromium.org/2200303003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp
> (right):
> 
>
https://codereview.chromium.org/2200303003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp:41: if
> (isTerminating(scriptState))
> On 2016/08/03 09:02:12, haraken wrote:
> > 
> > yhirano@, nhiroki@: Now that nhiroki@ removed the force termination from
> worker
> > threads, can we remove these isTerminating() checks? Or do we still need
them?
> 
> We don't need them. I haven't done modules/fetch and core/streams cleanup in
> order to keep the code easy to merge, but I will do the cleanup soon as the
> shipped feature is becoming stable recently.

Thanks, sounds good.

[commit-bot: I haz the power, 2016-08-03 09:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 09:20:34]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-08-03 09:27:34]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-08-03 09:27:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 09:38:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 09:38:26]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[haraken, 2016-08-03 09:39:11]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-08-03 09:39:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 10:06:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 10:06:16]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[haraken, 2016-08-03 10:47:05]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-08-03 10:47:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 12:42:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 12:43:51]

Description was changed from

==========
Remove v8CallOrCrash

Per the discussion in
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/vG...,
this CL replaces v8CallOrCrash with ToLocalChecked/ToChecked.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove v8CallOrCrash

Per the discussion in
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/vG...,
this CL replaces v8CallOrCrash with ToLocalChecked/ToChecked.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/6526c5b4ac92c26c3903146941ceb267422ebf8c
Cr-Commit-Position: refs/heads/master@{#409497}
==========

[commit-bot: I haz the power, 2016-08-03 12:43:52]

Patchset 2 (id:??) landed as
https://crrev.com/6526c5b4ac92c26c3903146941ceb267422ebf8c
Cr-Commit-Position: refs/heads/master@{#409497}