third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp - Issue 2200303003: Remove v8CallOrCrash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp

Issue 2200303003: Remove v8CallOrCrash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp » ('j') | third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp

index 1b0cd280d22046994bd4ac491358f88c8c2d8aad..2a5afedeebc50eb0294721cc4537b687f68e0cea 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp

@@ -90,7 +90,7 @@ v8::Local<v8::Value> V8ThrowException::createDOMException(v8::Isolate* isolate,

v8::Local<v8::Value> error = v8::Exception::Error(v8String(isolate, domException->message()));

ASSERT(!error.IsEmpty());

v8::Local<v8::Object> exceptionObject = exception.As<v8::Object>();

- v8CallOrCrash(exceptionObject->SetAccessor(isolate->GetCurrentContext(), v8AtomicString(isolate, "stack"), domExceptionStackGetter, domExceptionStackSetter, error));

+ exceptionObject->SetAccessor(isolate->GetCurrentContext(), v8AtomicString(isolate, "stack"), domExceptionStackGetter, domExceptionStackSetter, error).ToChecked();

auto privateError = V8PrivateProperty::getDOMExceptionError(isolate);

privateError.set(scriptState->context(), exceptionObject, error);