third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp - Issue 2200303003: Remove v8CallOrCrash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

Issue 2200303003: Remove v8CallOrCrash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h » ('j') | third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

index 09b9511915046992d16f5b9d2bf7da72b82c358b..4c555718f4377b3607bf6dacbc6cbf530c4f1360 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

@@ -19,7 +19,7 @@ v8::Local<v8::Value> V8PrivateProperty::Symbol::getFromMainWorld(ScriptState* sc

v8::Local<v8::Private> V8PrivateProperty::createV8Private(v8::Isolate* isolate, const char* symbol, size_t length)

{

- v8::Local<v8::String> str = v8CallOrCrash(v8::String::NewFromOneByte(isolate, reinterpret_cast<const uint8_t*>(symbol), v8::NewStringType::kNormal, static_cast<int>(length)));

+ v8::Local<v8::String> str = v8::String::NewFromOneByte(isolate, reinterpret_cast<const uint8_t*>(symbol), v8::NewStringType::kNormal, static_cast<int>(length)).ToLocalChecked();

return v8::Private::ForApi(isolate, str);

}